Skip to content

Documenting exit pages implementation mvp#217

Closed
christophercameron-ixd wants to merge 37 commits intomainfrom
documenting-exit-pages-implementation-MVP
Closed

Documenting exit pages implementation mvp#217
christophercameron-ixd wants to merge 37 commits intomainfrom
documenting-exit-pages-implementation-MVP

Conversation

@christophercameron-ixd
Copy link
Copy Markdown
Contributor

PR Checklist

  • Set yourself as the Assignee
  • Tag anyone you would like to review, or @forms-design or @forms-devs
  • Fill in the template below

What

Added the designs we explored for exit pages, and the concept for adding routes section to edit question page with a note for further exploration.

How to review

  1. Semantic: Do you agree with the changes?
  2. Syntactic: Spelling, grammar, etc.
  3. Is there anything missed or needing clarification?

Who can review

Anyone in the team but primarily those tagged for review.

Created initial outline using previous documentation of iteration 2. This is a placeholder for the new documentation - we have also separated the exit page documentation work into it’s own card... might be just as easy to put the documentation into this file too but not sure yet
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@christophercameron-ixd is this file meant to be in this commit? I think this is the same as the file in this pr: #214 ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeah, Lorna and I talked about this yesterday I think it’s because I took the base branch as the 214 one... which I think might’ve borked this a bit... I am curious to see what happens when I merge them in.

But basically if you reviewed it in the other PR just ignore it here and I’ll see what happens :)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm... I’m going to close this PR and have created a new one

@christophercameron-ixd
Copy link
Copy Markdown
Contributor Author

Closing as I had accidentally set the PR to compare with changes made from main instead of the branch I took this from

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants